Hello! Im implementing this plugin in my latest game Look Outside - and in working on it I found a few issues you might want to fix on your end-
in addShopStock, line 1262 - misnamed variable, it should be defaultStockMax, not defaultRestockMax
in the resetStock function, add a check to see if _shopstock is undefined, and if it is, initialize the 3 variables of the plugin - that way, old saves from before the plugin was implementing should work with the post-plugin version
will add to this in replies if I find more stuff!
Also - im not sure Im setting up the shops properly - it seems like, in order for the stocks to not reset every time the shop is launched, and to not break after loading the game, I need to use two Set Stock calls for each shop:
The first one is only called once per game and sets up the initial shop inventory
The second one just before the shop processing call, that doesnt have any inventory set up in it.
If I only do the first call, the shop works fine initially, but it breaks if I load the game.
if I only have that second call just before the shop processing event, and put the full shop inventory in that one call, the shop works but it resets the shop stock inventory every time the shop is called.
If that is the intended usage, I think it needs to be explained better in the plugin files - if its not the intended usage, I think I'm either doing something wrong, or it might not be working properly.
Thank you for choosing my plugin! Sorry for the delay in getting back to you, I've been crazy busy lately. I'll take a look at these issues as soon as I can, will hopefully have an update for you by end of next week at the latest (along with a fix for re3troo's issue below)
The 'sell' functionality appears to be broken in the current version - items you attempt to sell will end up back in your inventory after you leave the shop - and won't appear for sale in the shop you've sold to
Are you sure you're using the latest version? I've tested on both the free and paid plugins and if I sell an item, it's removed from my inventory and added to the shop's stock if it's one they sell.
Version 1.07 is now available and finally fixes the bug with stock! It turns out that there was a logic error that made it only use variables for stock quantities, so constant values no longer worked. This is now resolved.
Weird, that usually only happens on mobile. It's because of a browser that doesn't support null-coalescing assignment, which I use pretty liberally in my plugins unfortunately. It's client-end so there's no way for me to fix it besides not using those operators at all, which I'd rather not do since they're a really handy ES2020 feature.
If I get the time (and I'm not promising since my schedule is horrendously hectic at the best of times) I'll create a variant for you that doesn't use null-coalescing and put it up as a separate download. Did you buy the premium version or are you using the free one?
Version 1.06 has been released! Quantities can now be set via variable and cannot result in a stock value greater than the max restock value. I also fixed a bug where comparison between the stock equality check wasn't working properly.
Hey zelanius! I'd considered an MV version but I can't think of an elegant way to do the plugin commands that would still allow for the same versatility. If I come up with something I for sure will.
Thanks for the response, Trihan. I thought that might be the case, as I recall someone else (I think it was Ramza) who mentioned how MV was more difficult to build plugins for due to the way their script was structured. Hopefully, you will find a solution, as this would be a really nice way to limit item stocks and manage game difficulty (and force some crafting on top of that), instead of a tedious "Show Choice" menu with tied to various variables and switches which will certainly make me go @_@.
I am having a compatability issue with the plugin. Source maps of old save files will not load when the plugin is enabled. New game files run with no problem. I disabled Visustella Main Menu core but that did not help.
Okay, so the source map thing is entirely unrelated to the problem; that happens in all RM projects and can be safely ignored.
The actual issue is with the restock timers tracker. Did you add the plugin to an existing project and try to load a save you'd already created prior to installing it?
I did add it to an existing project. Is there a way to disable the global restock timer? Otherwise I can try setting restock to -1 and see if that helps.
Setting it to 0 does disable it, but the problem is the code is still checking for it being there so whether enabled or not you'll still have this issue. It's because the object is created on game start, so obviously it doesn't exist in your save.
I'll update the plugin to create the object if it doesn't exist when it's needed. Should have a new version up soon, thanks for the report!
← Return to plugin
Comments
Log in with itch.io to leave a comment.
Hello! Im implementing this plugin in my latest game Look Outside - and in working on it I found a few issues you might want to fix on your end-
will add to this in replies if I find more stuff!
Also - im not sure Im setting up the shops properly - it seems like, in order for the stocks to not reset every time the shop is launched, and to not break after loading the game, I need to use two Set Stock calls for each shop:
The first one is only called once per game and sets up the initial shop inventory
The second one just before the shop processing call, that doesnt have any inventory set up in it.
If I only do the first call, the shop works fine initially, but it breaks if I load the game.
if I only have that second call just before the shop processing event, and put the full shop inventory in that one call, the shop works but it resets the shop stock inventory every time the shop is called.
If that is the intended usage, I think it needs to be explained better in the plugin files - if its not the intended usage, I think I'm either doing something wrong, or it might not be working properly.
Thank you for choosing my plugin! Sorry for the delay in getting back to you, I've been crazy busy lately. I'll take a look at these issues as soon as I can, will hopefully have an update for you by end of next week at the latest (along with a fix for re3troo's issue below)
Thanks for making it, its very useful!
I buy this Plugin - its very nice :) but the variable addon not final working.
it adds the items via the variable this work but subtract it after buying nothing in the variable, i buy this for the variable =(
Oh, that's not good! I'll try to figure that out tomorrow for you. Thanks for the purchase!
Ho! Very Nice! Thx for your speed and hard work , Cheers :)
Is this compatible with the VisuStella shop stuff?
It should be. If there are any issues with it, let me know and I'll try to resolve them.
Thanks. ^^
It cannot be implemented in saved games, set property [object array] of the undefined... I have to test from scratch, then it works. Can fix?
I'll look into it! Thanks for the report.
Thanks, let me know.
Hi there! Liking this plugin, very user-friendly!
The 'sell' functionality appears to be broken in the current version - items you attempt to sell will end up back in your inventory after you leave the shop - and won't appear for sale in the shop you've sold to
Oh, that definitely sounds like a bug! Leave that with me and I'll post an update as soon as it's fixed.
Was that the free version or the premium one?
Are you sure you're using the latest version? I've tested on both the free and paid plugins and if I sell an item, it's removed from my inventory and added to the shop's stock if it's one they sell.
Version 1.07 is now available and finally fixes the bug with stock! It turns out that there was a logic error that made it only use variables for stock quantities, so constant values no longer worked. This is now resolved.
I'm getting this error when launching my project with this plugin enabled.
I tried turning off all my other plugins to see if it will work and it still throws up the same error.
Are you trying to run it on a mobile device with Android 4 or earlier?
Nope, I'm on windows 10.
Weird, that usually only happens on mobile. It's because of a browser that doesn't support null-coalescing assignment, which I use pretty liberally in my plugins unfortunately. It's client-end so there's no way for me to fix it besides not using those operators at all, which I'd rather not do since they're a really handy ES2020 feature.
Ah that's unfortunate, thank you for responding though!
If I get the time (and I'm not promising since my schedule is horrendously hectic at the best of times) I'll create a variant for you that doesn't use null-coalescing and put it up as a separate download. Did you buy the premium version or are you using the free one?
It looks like 1.06 has caused a bug where shops are always sold out; I'm currently looking into this and will update as soon as I resolve it.
Version 1.06 has been released! Quantities can now be set via variable and cannot result in a stock value greater than the max restock value. I also fixed a bug where comparison between the stock equality check wasn't working properly.
Hi, I bought this plugin, it's ALMOST perfect for my game, but I may be doing something wrong. So,
- I'd like to disable auto-restock and only do it via plugin command when a certain point of my game is reached
- I set the default stock maximum to 5
But if I use a plugin command to add, say, 10 items, it will go above the stock maximum! Is there a way to control this?
Thank you
Hi Trihan, any plans to port this to MV?
Hey zelanius! I'd considered an MV version but I can't think of an elegant way to do the plugin commands that would still allow for the same versatility. If I come up with something I for sure will.
Thanks for the response, Trihan. I thought that might be the case, as I recall someone else (I think it was Ramza) who mentioned how MV was more difficult to build plugins for due to the way their script was structured. Hopefully, you will find a solution, as this would be a really nice way to limit item stocks and manage game difficulty (and force some crafting on top of that), instead of a tedious "Show Choice" menu with tied to various variables and switches which will certainly make me go @_@.
Since it's you I'm sure I can figure something out.
Is there a way to specify item quantity adjustments using a variable?
Not yet, but someone else requested it and I'm planning to include that as a feature in the next version, which should be available soon.
I am having a compatability issue with the plugin. Source maps of old save files will not load when the plugin is enabled. New game files run with no problem. I disabled Visustella Main Menu core but that did not help.
Sorry to hear that! I'll take a look.
Okay, so the source map thing is entirely unrelated to the problem; that happens in all RM projects and can be safely ignored.
The actual issue is with the restock timers tracker. Did you add the plugin to an existing project and try to load a save you'd already created prior to installing it?
I did add it to an existing project. Is there a way to disable the global restock timer? Otherwise I can try setting restock to -1 and see if that helps.
Setting it to 0 does disable it, but the problem is the code is still checking for it being there so whether enabled or not you'll still have this issue. It's because the object is created on game start, so obviously it doesn't exist in your save.
I'll update the plugin to create the object if it doesn't exist when it's needed. Should have a new version up soon, thanks for the report!
Is the update available? Sorry, I can't seem to see the versions
I am getting this when running the plugin in play test after following your instructions.
SyntaxError
Unexpected token '='
Can you please help?
Of course! I'm so sorry to hear that and thanks so much for the purchase.
What have you done in terms of shop setup?
Just checking in for this since it's been 2 months. I can't help you without some more information. ^_^